Update to SystemView v3.58 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert all files in repository to Unix style LF line endings (`\n`). Trailing whitespace is also trimmed. No functional changes. Signed-off-by: Bryce Wilkins <[email protected]>
Integrate Zephyr changes with Segger SystemView target source v3.58 Signed-off-by: Bryce Wilkins <[email protected]>
Contributor
Author
|
@cfriedt The suggestion for Unix style line endings is accommodated in this PR. @henrikbrixandersen @nordic-krch @nordicjm Hope you are able to have a look. Thank you! |
nordic-krch
approved these changes
Dec 9, 2024
Contributor
Author
|
@cfriedt @henrikbrixandersen Would you be able to have a look? Thank you! |
henrikbrixandersen
requested changes
Dec 16, 2024
Member
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Looks good, one small nit.
brycewilkins
force-pushed
the
bw/segger_line_endings
branch
from
bfbb570 to
4a23974
Compare
Add README.md that identifies the origin of Segger source files and provide a procedure for migrating Zephyr changes to new Segger releases. Signed-off-by: Bryce Wilkins <[email protected]>
brycewilkins
force-pushed
the
bw/segger_line_endings
branch
from
4a23974 to
4a7b86e
Compare
henrikbrixandersen
approved these changes
Dec 17, 2024
kartben
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository has suffered a few setbacks over past years with Zephyr related patches being lost (causing things to break for RTT/SystemView/Zephyr), and it has been reported as hard to review PRs due to Windows style line endings. There is also no instruction on how to update from the existing Segger source code to a newer release, leading to partial updates that make subsequent updates more difficult and error prone.
This PR attempts to improve things by:
\n)To do:
Platform: